docs(sui): point Sui integration links at the new docs URL#3677
docs(sui): point Sui integration links at the new docs URL#36770xghost42 wants to merge 2 commits into
Conversation
Closes pyth-network#3228. The Sui READMEs link to ``docs.pyth.network/documentation/pythnet-price-feeds/sui``, which returns HTTP 404 since the docs site reshuffle. The maintainer confirmed the current URL on the issue: ``docs.pyth.network/price-feeds/core/contract-addresses/sui`` (HTTP 200). Update both occurrences: * ``target_chains/sui/README.md`` (the link the bug report points at) * ``target_chains/sui/sdk/js-iota/README.md`` (the same URL in a code comment showing where to find Pyth/Wormhole state IDs) Verified with ``curl -sI``: * old URL -> 404 * new URL -> 200 Other ``documentation/pythnet-price-feeds/<topic>`` URLs in the repo are out of scope for this fix; they cover non-Sui topics and the new URL for each is not 1:1 with the old one.
|
@0xghost42 is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Per Devin Review on pyth-network#3677, the same stale URL appears in two CLI `--help` descriptions in apps/price_pusher/src/sui/command.ts. Update both to match the rest of the PR.
|
Thanks for the catch — pushed 890dd8c which updates both CLI help descriptions in |
| const wallet: SignerWithProvider = getWallet(); | ||
| // Get the state ids of the Pyth and Wormhole contracts from | ||
| // https://docs.pyth.network/documentation/pythnet-price-feeds/sui | ||
| // https://docs.pyth.network/price-feeds/core/contract-addresses/sui |
There was a problem hiding this comment.
🚩 Other old-style documentation URLs remain in the same IOTA README
The js-iota README at target_chains/sui/sdk/js-iota/README.md still contains two other old-style URLs that were not updated by this PR: line 23 (docs.pyth.network/documentation/pythnet-price-feeds/on-demand) and line 155 (docs.pyth.network/documentation/pythnet-price-feeds/hermes#public-endpoints). These are different pages (on-demand and hermes) rather than the Sui contract addresses page, so they may intentionally be out of scope for this PR. However, if the goal is to migrate all docs URLs, these should be updated too — possibly as a follow-up.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Re: Devin review findings —
|
1 participant
Summary
Closes #3228.
The Sui READMEs link to
docs.pyth.network/documentation/pythnet-price-feeds/sui, which returns HTTP 404 since the docs site reshuffle. @merolish confirmed on the issue that the current URL isdocs.pyth.network/price-feeds/core/contract-addresses/sui.Change
Update both Sui-specific occurrences of the broken URL:
target_chains/sui/README.md(the link the bug report points at)target_chains/sui/sdk/js-iota/README.md(the same URL in a code comment showing where to find Pyth/Wormhole state IDs)Verification
Out of scope
Other
documentation/pythnet-price-feeds/<topic>URLs in the repo (best-practices, on-demand, hermes, near, ...) cover non-Sui topics and the new URL for each is not necessarily a 1:1 mapping with the old one. Happy to follow up with a broader sweep in a separate PR if you'd like.