docs(aptos): document why framework dependency revisions are pinned#3690
Open
0xghost42 wants to merge 1 commit into
Open
docs(aptos): document why framework dependency revisions are pinned#36900xghost42 wants to merge 1 commit into
0xghost42 wants to merge 1 commit into
Conversation
Closes pyth-network#2511. The Move.toml in target_chains/aptos/contracts pins AptosFramework, MoveStdlib, AptosStdlib, and AptosToken to a specific aptos-core revision that predates several recent mainnet upgrades. Without context, contributors keep filing issues / PRs proposing to bump these revs to 'latest mainnet' — which would silently break ABI compatibility with the on-chain Wormhole package the Pyth contract depends on. Add a comment above the dependencies block explaining why the rev is locked and that it cannot be bumped in isolation from a coordinated Wormhole upgrade on every supported network.
|
@0xghost42 is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2511.
The Move.toml in
target_chains/aptos/contracts/pinsAptosFramework,MoveStdlib,AptosStdlib, andAptosTokento a specificaptos-corerevision that predates several recent mainnet upgrades. Without context, contributors keep proposing to bump these to "latest mainnet" — which would silently break ABI compatibility with the on-chain Wormhole package the Pyth contract depends on.This PR adds a short comment above the
[dependencies]block explaining:aptos-corerev that the deployed Wormhole package was compiled against).Change
One file, six lines of comments added — no code or version changes:
target_chains/aptos/contracts/Move.tomlVerification
[dependencies]table, parsed identically to the existing trailing[dev-addresses]comment (line 20–21).move buildproduces identical bytecode.Out of scope
The issue also asks about updating the rev to a newer mainnet version. That's a deployment-coordination question (needs Wormhole + Pyth governance + redeploy on every chain) and well outside what an outside PR should attempt. This change just documents the lock so the question doesn't keep recurring.