chore(apps/hip-3-relayer): Fix Scripts, Add Testnet Drip, Bump Version#3709
chore(apps/hip-3-relayer): Fix Scripts, Add Testnet Drip, Bump Version#3709darunrs wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
UV Lock update is from a local uv build. It was not touched by an agent. |
There was a problem hiding this comment.
🚩 Pre-existing bug: type=bool in argparse makes --to-perp False always True
The --to-perp argument at apps/hip-3-pusher/src/scripts/usd_class_transfer.py:25-29 uses type=bool, which is a well-known Python argparse footgun. argparse calls bool(string_value), and since bool("False") evaluates to True (any non-empty string is truthy), it's impossible to pass False through the CLI. Combined with required=True, every invocation will set to_perp=True. The fix would be to use action="store_true" / action="store_false" or a custom type function. This is pre-existing (not introduced by this PR) but worth noting since the file was touched.
(Refers to lines 25-29)
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Rationale
How has this been tested?