Skip to content

chore(apps/hip-3-relayer): Fix Scripts, Add Testnet Drip, Bump Version#3709

Open
darunrs wants to merge 4 commits into
mainfrom
bump-fix-script
Open

chore(apps/hip-3-relayer): Fix Scripts, Add Testnet Drip, Bump Version#3709
darunrs wants to merge 4 commits into
mainfrom
bump-fix-script

Conversation

@darunrs
Copy link
Copy Markdown
Contributor

@darunrs darunrs commented May 15, 2026

Summary

  • Adds script for testnet drip
  • Fixes script errors
  • Bumps version for hip 3 relayer
  • Updates lock file from build

Rationale

  • Some script fixes were made, and need to be propagated to the pods

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Open in Devin Review

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-reference Error Error May 15, 2026 10:28pm
component-library Ready Ready Preview, Comment May 15, 2026 10:28pm
developer-hub Error Error May 15, 2026 10:28pm
entropy-explorer Error Error May 15, 2026 10:28pm
insights Error Error May 15, 2026 10:28pm
proposals Ready Ready Preview, Comment May 15, 2026 10:28pm
staking Error Error May 15, 2026 10:28pm

Request Review

@darunrs
Copy link
Copy Markdown
Contributor Author

darunrs commented May 15, 2026

UV Lock update is from a local uv build. It was not touched by an agent.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing bug: type=bool in argparse makes --to-perp False always True

The --to-perp argument at apps/hip-3-pusher/src/scripts/usd_class_transfer.py:25-29 uses type=bool, which is a well-known Python argparse footgun. argparse calls bool(string_value), and since bool("False") evaluates to True (any non-empty string is truthy), it's impossible to pass False through the CLI. Combined with required=True, every invocation will set to_perp=True. The fix would be to use action="store_true" / action="store_false" or a custom type function. This is pre-existing (not introduced by this PR) but worth noting since the file was touched.

(Refers to lines 25-29)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants