-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-146401: add BuiltinImporter.discover() to find built-in modules
#146421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Locked-chess-official
wants to merge
5
commits into
python:main
Choose a base branch
from
Locked-chess-official:suggest_builtin_module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−0
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c01925d
just change traceback.py to make it
Locked-chess-official b57a7e7
add test (why who added the suggestion for module name didn't add the…
Locked-chess-official 03a9290
Revert "just change traceback.py to make it"
Locked-chess-official a06d51a
revert change in traceback and add discover
Locked-chess-official 1621018
Update Lib/importlib/_bootstrap.py
Locked-chess-official File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -938,6 +938,14 @@ def is_package(cls, fullname): | |
| """Return False as built-in modules are never packages.""" | ||
| return False | ||
|
|
||
| @classmethod | ||
| def discover(cls, spec=None): | ||
| if spec is not None: # assume that built-in modules have no submodule | ||
| return | ||
| for i in sys.builtin_module_names: | ||
| if i_spec := cls.find_spec(i): | ||
| yield i_spec | ||
|
picnixz marked this conversation as resolved.
Outdated
|
||
|
|
||
|
Comment on lines
+946
to
+948
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are other discover() methods meant to return a list or an iterator |
||
|
|
||
| class FrozenImporter: | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add tests for that? and a documentation entry as well? or maybe let's ask @FFY00 if he wants to make this API documented (if not, we can rename the PR to "Include built-in modules in traceback suggestions")