gh-146578: _zstd: Fix printf format for pledged size errors#146576
Open
cuiweixie wants to merge 1 commit intopython:mainfrom
Open
gh-146578: _zstd: Fix printf format for pledged size errors#146576cuiweixie wants to merge 1 commit intopython:mainfrom
cuiweixie wants to merge 1 commit intopython:mainfrom
Conversation
Use %llu instead of %ull for unsigned long long in zstd_contentsize_converter ValueError messages.
cuiweixie
changed the title
picnixz
approved these changes
Mar 28, 2026
picnixz
added
skip news
needs backport to 3.14
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Good catch! Could you please add tests?
Most likely there are already tests for passing out of range size argument, but they do not test the error message or the test is too lenient. You can change ValueError to something other, like SystemError, run the test and look what fails.
Member
|
Inspired by this, I wrote a plugin to capture similar issues. Are you guys interested? I can open a new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace invalid
%ullwith%lluinzstd_contentsize_converterValueErrorformat strings. The correct specifier for
unsigned long longis%llu.Test plan
_zstd; change affects error-message formatting only.