Skip to content

gh-146579: _zstd: Fix decompression options dict error message#146577

Open
cuiweixie wants to merge 1 commit intopython:mainfrom
cuiweixie:fix-zstd-decompressor-options-msg
Open

gh-146579: _zstd: Fix decompression options dict error message#146577
cuiweixie wants to merge 1 commit intopython:mainfrom
cuiweixie:fix-zstd-decompressor-options-msg

Conversation

@cuiweixie
Copy link
Copy Markdown
Contributor

@cuiweixie cuiweixie commented Mar 28, 2026

Summary

Fix the TypeError string in _zstd_set_d_parameters: it incorrectly said
compression options dictionary when validating decompression option keys.

Test plan

  • No behavior change beyond the error text; optional manual check by passing an
    invalid key type to decompression options.

The TypeError in _zstd_set_d_parameters incorrectly referred to
compression options; say decompression options instead.
@cuiweixie cuiweixie changed the title _zstd: Fix decompression options dict error message gh-146579: _zstd: Fix decompression options dict error message Mar 28, 2026
@serhiy-storchaka
Copy link
Copy Markdown
Member

I am not sure this is a bug. Should not the compression options dictionary be the same for compression and decompression? They are compression options which should be passed to decompressor to inform what options were used during compression.

@picnixz
Copy link
Copy Markdown
Member

picnixz commented Mar 29, 2026

Should not the compression options dictionary be the same for compression and decompression?

They actually differ:

@serhiy-storchaka
Copy link
Copy Markdown
Member

You are right. This check is especially to check that they are not mixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants