gh-91167: Fix cloned turtle pen not clearing completely#146660
Open
yukarikaname wants to merge 2 commits intopython:mainfrom
Open
gh-91167: Fix cloned turtle pen not clearing completely#146660yukarikaname wants to merge 2 commits intopython:mainfrom
yukarikaname wants to merge 2 commits intopython:mainfrom
Conversation
When calling clear() on a cloned turtle, it incorrectly cleared the source turtle's drawings instead of its own. Fix by reinitializing the clone's currentLine and items to track only its own drawing state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling clear() on a cloned turtle, it incorrectly cleared the source
turtle's drawings instead of its own.
The issue was in RawTurtle.clone(): after deepcopy(), the clone inherited
the source turtle's currentLine and items lists, causing the clone's
clear() to delete items owned by the source turtle.
Fix by reinitializing currentLine and items for the clone to track only
its own drawing state.