Skip to content

gh-146656: properly raise NotImplementedError instead of NotImplemented in test_discover #146661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Locked-chess-official wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

gh-146656: properly raise NotImplementedError instead of NotImplemented in test_discover #146661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/test_discover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def __init__(self, discover=[]):
self._discovered_values = discover

def find_spec(self, fullname, path=None, target=None):
raise NotImplemented
raise NotImplementedError
Copy link
Copy Markdown
Member

@aisk aisk Apr 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to raise an exception instance instead of an exception class.

Suggested change
raise NotImplementedError
raise NotImplementedError()


def discover(self, parent=None):
yield from self._discovered_values
Expand Down
Loading