gh-131798: JIT inline function addresses of builtin methods #146906
Draft
kumaraditya303 wants to merge 7 commits intopython:mainfrom
Draft
gh-131798: JIT inline function addresses of builtin methods #146906kumaraditya303 wants to merge 7 commits intopython:mainfrom
kumaraditya303 wants to merge 7 commits intopython:mainfrom
Conversation
Member
|
Edit: I might be wrong on the following, so please ignore the rest. Really sorry I just realised this optimization may not be sound: The builtin call specializations only check for that the builtin tp flags match, I don't think they check for tp_version_tag and such. So we can have a method that changes its tp_slots under our feet. Sorry for taking up your time! |
Member
|
The rewriting that we discussed might still pay off though (rewriting That should also be sound, provided we have the correct guards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.