gh-143930: Fix typo in NEWS entry#147948
gh-143930: Fix typo in NEWS entry#147948benediktjohannes wants to merge 1 commit intopython:mainfrom
Conversation
|
Please apply skip issue, thanks! |
|
This can be included in #146476. |
|
I don't think it's actually worth it. The NEWS entry was backported to security branches, so I prefer that it's amended in #146476 directly. |
As I said in the past, let maintainers decide what labels to add. Don't ask them please. In this case, a skip issue would not be correct and the change itself was not motivating enough as it would have required backports to security branches. |
Ah, thank you for telling me about this, it's a good idea to use the other PR for this! 👍 |
|
And sorry for the label comment, I didn't ping anyone for this, I just thought that this label was correct and needed because the check failed, sorry, now I know for the future! |
We do always include a "." at the end of the Whats New statement in the release notes (see
gh-143935: Fixed a bug in the folding of comments when flattening an email message using a modern email policy. Comments consisting of a very long sequence of non-foldable characters could trigger a forced line wrap that omitted the required leading space on the continuation line, causing the remainder of the comment to be interpreted as a new header field. This enabled header injection with carefully crafted inputs.
gh-143925: Reject control characters in data: URL media types.
gh-143919: Reject control characters in http.cookies.Morsel fields and values.
gh-143916: Reject C0 control characters within wsgiref.headers.Headers fields, values, and parameters.
)
And Benedikt Tran said that it's not necessary to open up an issue for just fixing a typo, but I don't know whether formating of the title is correct now because of the missing issue