gh-147965: Add shutdown() to multiprocessing.Queue excluded methods#147970
Open
WYSIATI wants to merge 1 commit intopython:mainfrom
Open
gh-147965: Add shutdown() to multiprocessing.Queue excluded methods#147970WYSIATI wants to merge 1 commit intopython:mainfrom
WYSIATI wants to merge 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
WYSIATI
requested review from
AA-Turner,
ezio-melotti,
hugovk and
webknjaz
as code owners
Member
|
Please avoid modify unrelated files in one PR. |
Contributor
Member
|
And if this PR is fully generated by LLM, please read https://devguide.python.org/getting-started/generative-ai/ first. @WYSIATI |
…hods The multiprocessing.Queue documentation states it implements all methods of queue.Queue except task_done() and join(). Since queue.Queue.shutdown() was added in Python 3.13, multiprocessing.Queue also does not implement it. Update the docs to include shutdown() in the list of excluded methods.
WYSIATI
force-pushed
the
fix-mp-queue-shutdown-docs-147965
branch
from
d3b06be to
fe18363
Compare
Author
|
@aisk Thanks for the pointer, I used AI to assist me with writing the commit, but I personally verify it the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147965.
The
multiprocessing.Queuedocumentation states it implements all methods ofqueue.Queueexcept fortask_done()andjoin(). Sincequeue.Queue.shutdown()was added in Python 3.13, andmultiprocessing.Queuedoes not implement it either, this PR addsshutdown()to the list of excluded methods.Changes
Doc/library/multiprocessing.rst: Addshutdown()to the list ofqueue.Queuemethods not implemented bymultiprocessing.Queuemultiprocessing.Queuedoes not implement theshutdownmethod. #147965📚 Documentation preview 📚: https://cpython-previews--147970.org.readthedocs.build/