gh-145000: find correct merge base in check-html-ids#147975
Open
StanFromIreland wants to merge 2 commits intopython:mainfrom
Open
gh-145000: find correct merge base in check-html-ids#147975StanFromIreland wants to merge 2 commits intopython:mainfrom
StanFromIreland wants to merge 2 commits intopython:mainfrom
Conversation
StanFromIreland
requested review from
AA-Turner,
ezio-melotti,
hugovk and
webknjaz
as code owners
StanFromIreland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.event.pull_request.base.shais not the same as thegit merge-base, per https://github.com/orgs/community/discussions/39880. Instead compare the commits and usemerge_base_commit(this also however has quite sparse docs :-( at https://docs.github.com/en/rest/commits/commits?apiVersion=2026-03-10&versionId=free-pro-team%40latest&category=commits&subcategory=commits#compare-two-commits).