gh-131372: Configurable build-details.json name#150098
Conversation
stefanor
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
|
I would prefer to rename the configure option to something like What do you think? |
|
That works for me! |
stefanor
force-pushed
the
build-detials-name
branch
from
b6759d2 to
1345552
Compare
Linux distributions that co-install multiple Python versions in the same path (e.g. multiarch on Debian, debug builds, and free-threading) need a way to place multiple build-details.jsons side-by-side. PEP-739 is being updated [0] to recommend renaming in this situation. To ensure some standardization, this PR generates appropriate names for distributions that need to use this feature. [0]: python/peps#4889
stefanor
force-pushed
the
build-detials-name
branch
from
1345552 to
adb7586
Compare
|
@FFY00: Implemented that |
|
Can we have an issue for those kind of changes? this is solely so that people can more easily report issues later and for cross-references (or use an existing one) |
stefanor
changed the title
Ah, there was already an issue, I'd forgotten about it. |
stefanor
force-pushed
the
build-detials-name
branch
from
a606e8b to
900ec0d
Compare
picnixz
changed the title
|
|
||
| # Check for --with-build-details-suffix | ||
| BUILD_DETAILS=build-details.json | ||
| AC_ARG_WITH([build-details-suffix], |
There was a problem hiding this comment.
Can you please document the new option in Doc/using/configure.rst?
| @@ -0,0 +1,3 @@ | |||
| Add a ``--with-build-details-suffix=`` configure flag to allow Linux | |||
| distributions that co-install multiple versions of Python in the same tree | |||
| to avoid ``build-details.json`` clashes. | |||
There was a problem hiding this comment.
It may be worth it to document the new option in Doc/whatsnew/3.16.rst in the "Build changes" section:
https://docs.python.org/dev/whatsnew/3.16.html#build-changes
| @@ -0,0 +1,3 @@ | |||
| Add a ``--with-build-details-suffix=`` configure flag to allow Linux | |||
There was a problem hiding this comment.
If you document the option in Doc/using/configure.rst, you can add a link to it:
| Add a ``--with-build-details-suffix=`` configure flag to allow Linux | |
| Add a :option:`--with-build-details-suffix` configure flag to allow Linux |
4 participants
Linux distributions that co-install multiple Python versions in the same path (e.g. multiarch on Debian, debug builds, and free-threading) need a way to place multiple
build-details.jsons side-by-side.PEP-739 is being updated to recommend renaming in this situation. To ensure some standardisation, this PR generates appropriate names for distributions that need to use this feature. The name will be exposed in
sysconfig.My first preference would be to always do this, using the
ABIFLAGSdirectly in the name. But this leads to less-human-readable names and the PEP authors preferred a static name where possible and a more verbose name, when we choose to rename.@FFY00