gh-152959: Raise ValueError for a <key> outside a <dict> in plistlib#152960
Open
tonghuaroot wants to merge 1 commit into
Open
gh-152959: Raise ValueError for a <key> outside a <dict> in plistlib#152960tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…stlib _PlistParser.end_key evaluated self.stack[-1] before checking whether the stack was empty, so a <key> element outside a <dict> (for example at the document root) leaked an IndexError instead of a ValueError. Guard the empty-stack case, matching the sibling add_object handler. The binary plist format does not use this path and is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PlistParser.end_keyinLib/plistlib.pyevaluatedself.stack[-1]beforechecking whether the stack was empty, so a
<key>element outside a<dict>(for example at the document root) leaked an
IndexErrorfromplistlib.loadsinstead of aValueError. The guard now short-circuits on anempty stack, raising
ValueErrorconsistently with the sibling<integer>and
<real>elements (which go throughadd_object, already guarded). Thebinary plist format decodes with
struct.unpackand is unaffected.