gh-152959: Fix IndexError when <key> appears outside <dict> in plistlib#152970
Open
Wojusensei wants to merge 2 commits into
Open
gh-152959: Fix IndexError when <key> appears outside <dict> in plistlib#152970Wojusensei wants to merge 2 commits into
Wojusensei wants to merge 2 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
|
can someone plz add the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152959
when parsing an XML plist file, if a
<key>element appears outside of a<dict>container, the parser currently raises anIndexErrorbecause the stack is empty. This error is confusing and doesn't help users understand the real issuethis pr adds a check at the start of
end_key()to verify that the stack is not empty. if it is empty, we raiseInvalidFileExceptionwith a clear message that includes the line number, so users immediately know the plist file is malformed4 example the following invalid plist now produces a meaningful error instead of an
foo barIndexError: