Fixed type hint issues in SphinxAdapter class #15790
Open
mrhx01 wants to merge 9 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Removed overloads for the __call__ method in sphinx.pyi.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This has some fairly self-explanatory pre-commit errors. Please fix those, before we can review the PR. (See also the comment on your other PRs on how to work around the Y011 problem.) |
Removed unused docstring parameters from the deprecation function.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Thanks! Fixed the Y011 and Y021 errors. Ready for another review.
|
srittau
previously approved these changes
May 19, 2026
srittau
requested changes
May 19, 2026
| line_length: int = 70, | ||
| ) -> None: ... | ||
| def __call__(self, wrapped: _F) -> Callable[[_F], _F]: ... | ||
| def get_deprecated_msg(self, wrapped: Any, instance: Any) -> str: ... |
Collaborator
There was a problem hiding this comment.
No need to include this method, as it is inherited from ClassicAdapter anyway (and should have an identical signature there).
Removed the get_deprecated_msg method from the sphinx.pyi stub.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add overload for call and missing method in sphinx.py
deprecated/sphinx.py
https://github.com/laurent-laporte-pro/deprecated/blob/master/deprecated/sphinx.py