Add functools.partial.__get__ for Python 3.14#15977
Open
apoorvdarshan wants to merge 1 commit into
Open
Conversation
partial became a descriptor in 3.14 (python/cpython#121027).
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15974.
Python 3.14 made
functools.partiala descriptor (python/cpython#121027), adding a__get__method, but the stub was missing it.This adds
__get__topartial, gated onsys.version_info >= (3, 14), mirroring the existingpartialmethod.__get__in the same file (-> Callable[..., _T]).The runtime signature on 3.14 is
(self, instance, owner=None, /)(positional-only), which the stub matches. When accessed on an instance the descriptor returns a boundmethod; on the class it returns thepartialitself — both areCallable[..., _T].python tests/stubtest_stdlib.py functoolspasses on 3.14 with this change (no new stubtest errors), andtests/mypy_test.py stdlib/functools.pyisucceeds.Disclosure: this change was prepared with the assistance of an AI tool (Claude Code). I verified the behavior against CPython 3.14, ran stubtest and the mypy test locally, and take responsibility for the contribution and will respond to review feedback personally.