Skip to content

[socket] Use concrete classes for socket.makefile return types #16587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srittau wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[socket] Use concrete classes for socket.makefile return types #16587

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd767d2
Remove socket.makefile fallback overload
srittau Oct 21, 2026
9496991
Remove unnecessary import
srittau Oct 21, 2026
54a5e50
Restore overload, but return union
srittau Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/socket.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ from _socket import (
from _typeshed import ReadableBuffer, Unused, WriteableBuffer
from collections.abc import Iterable
from enum import IntEnum, IntFlag
from io import BufferedReader, BufferedRWPair, BufferedWriter, IOBase, RawIOBase, TextIOWrapper
from io import BufferedReader, BufferedRWPair, BufferedWriter, RawIOBase, TextIOWrapper
from typing import Any, Final, Literal, Protocol, SupportsIndex, TypeAlias, overload, type_check_only
from typing_extensions import Self

Expand Down Expand Up @@ -1507,7 +1507,7 @@ class socket(_socket.socket):
encoding: str | None = None,
errors: str | None = None,
newline: str | None = None,
) -> IOBase: ...
) -> SocketIO | BufferedRWPair | BufferedReader | BufferedWriter: ...
@overload
def makefile(
self,
Expand Down
Loading