Skip to content

Fixed a bug when subscribing and unsubscribing in callback handling #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasTJdev merged 2 commits into from
Aug 7, 2025
Merged

Fixed a bug when subscribing and unsubscribing in callback handling #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d116ff4
separate calls of callbacks
python36 May 30, 2025
af0d070
Merge remote-tracking branch 'origin/master' into separate_call_callb…
ThomasTJdev Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions nmqtt.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,18 +835,19 @@ proc onPublish(ctx: MqttCtx, pkt: Pkt) {.async.} =
verbose("Retained ", mqttbroker.retained)

when not defined(broker):
var callbacks: seq[PubCallback]
for top, cb in ctx.pubCallbacks:
if top == topic or top == "#":
cb.cb(topic, message)
callbacks.add(cb)
if top.endsWith("/#"):
# the multi-level wildcard can represent zero levels.
if topic == top[0 .. ^3]:
cb.cb(topic, message)
callbacks.add(cb)
continue
var topicw = top
topicw.removeSuffix("#")
if topic.contains(topicw):
cb.cb(topic, message)
callbacks.add(cb)
if top.contains("+"):
var topelem = split(top, '/')
if len(topelem) == count(topic, '/') + 1:
Expand All @@ -855,7 +856,9 @@ proc onPublish(ctx: MqttCtx, pkt: Pkt) {.async.} =
if topelem[i] != "+" and e != topelem[i]: break
i = i+1
if i == len(topelem):
cb.cb(topic, message)
callbacks.add(cb)
for cb in callbacks:
cb.cb(topic, message)

if qos == 1:
ctx.workQueue[msgId] = Work(wk: PubWork, msgId: msgId, state: WorkNew, qos: 1, typ: PubAck)
Expand Down