Ensure only one active ping worker per connection#50
Open
centurysys wants to merge 1 commit intopython36:masterfrom
Open
Ensure only one active ping worker per connection#50centurysys wants to merge 1 commit intopython36:masterfrom
centurysys wants to merge 1 commit intopython36:masterfrom
Conversation
When reconnecting, runPing() is started again while previous ping workers may still be running. Since the worker references `ctx` (and not a specific socket instance), it can continue operating after a reconnect and use the updated socket. This can result in multiple concurrent ping workers sending PINGREQ frames at the keepAlive interval. Introduce a simple generation guard (pingWorkerId) that is incremented on each successful connection. Each ping worker stores the generation it was started with and exits if it detects a newer generation. This guarantees that only one active ping worker exists per connection without introducing additional synchronization primitives or changing public APIs. Signed-off-by: Takeyoshi Kikuchi <kikuchi@centurysys.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reconnecting, runPing() is started again while previous ping workers may still be running. Since the worker references
ctx(and not a specific socket instance), it can continue operating after a reconnect and use the updated socket.This can result in multiple concurrent ping workers sending PINGREQ frames at the keepAlive interval.
Introduce a simple generation guard (pingWorkerId) that is incremented on each successful connection. Each ping worker stores the generation it was started with and exits if it detects a newer generation.
This guarantees that only one active ping worker exists per connection without introducing additional synchronization primitives or changing public APIs.