ci: declare contents:read on Lint workflow#4193
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4193
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The pre-commit-checks job runs pre-commit hooks inside a miniconda env and a final `git diff`. No GitHub API write beyond actions/checkout. contents:read is the floor. Style matches the per-job permissions blocks already declared by the build-* / unittest-* / docs-* workflows in this repo (typically id-token: write + contents: read at the job level). Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
chore/lint-permissions
branch
from
b6ca980 to
b265e99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Lintworkflow runspre-commit run --all-filesinside aconda-incubator/setup-minicondaenv, thengit diffto surface any pre-commit-applied changes. No GitHub API write, no comment-on-PR step.This patch pins the workflow to
permissions: contents: read, matching the per-job permission blocks already declared by the build / unittest / docs workflows in this repo (typicallyid-token: write+contents: readfor the reusable-test callers).With explicit scope:
Token-Permissionscheck passes for this fileconda-incubator/setup-minicondaoractions/checkout(cf. tj-actions/changed-files CVE-2025-30066) stays boxed in read-onlyunittest-windows-cpu.ymlandunittest-windows-gpu.ymlare the other workflows without a permissions block, but they useactions/cacheand a more involved windows test setup, so I've left them out of this PR to keep the change focused and avoid the cache-write permissions discussion.No behavioural change.