Fix dead PhotoTour dataset docstring link#9493
Conversation
The docstring of PhotoTour pointed at http://matthewalunbrown.com/patchdata/ which now 301-redirects to a root page; the dataset itself moved to Brown's UW project page at https://phototour.cs.washington.edu/patches/ default.htm. Update the docstring link. Fixes pytorch#8722
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9493
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @adityasingh2400! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
The
PhotoTourdataset class's docstring linked tohttp://matthewalunbrown.com/patchdata/patchdata.html, which no longer hosts the dataset. The domainmatthewalunbrown.com301-redirects allpatchdata/paths to the site root, which currently serves unrelated commercial content.This patch updates the
Multi-view Stereo Correspondencelink in thePhotoTourdocstring to point at the original UW project pagehttps://phototour.cs.washington.edu/patches/default.htm, which still serves and which the existing note in the same docstring already references as the original dataset page.Scope is limited to the docstring link. The download URLs in the
urlsdict also appear to be broken (see #8722), but per the maintainer comment on that issue there is no known working replacement for the actual*_harris.ziparchives, so those are intentionally left alone in this PR.Fixes #8722
Test plan
curl -I https://phototour.cs.washington.edu/patches/default.htmreturnsHTTP/1.1 200 OK