fix(scan): skip invalid package specifiers instead of crashing#880
Open
raywcm wants to merge 1 commit into
Open
fix(scan): skip invalid package specifiers instead of crashing#880raywcm wants to merge 1 commit into
raywcm wants to merge 1 commit into
Conversation
…o#873) Invalid specifier strings (e.g. '=2.7.0' in the tensorflow vulnerability database entry) cause a crash with an unhandled InvalidSpecifier exception from packaging.specifiers. This fix wraps the SpecifierSet() parsing in a try/except to gracefully skip invalid specifiers with a warning log message, allowing the scan to continue normally.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
safety scanagainst an environment withtensorflowcauses an unhandled crash:The tensorflow vulnerability database entry contains the invalid specifier string
"=2.7.0"(single equals sign), which is not a valid PEP 440 specifier. TheSpecifierSet()parser frompackaging.specifiersraisesInvalidSpecifier, and the exception propagates unhandled.Reproduction
Install tensorflow and run
safety scan:Expected: the scan completes, reporting known vulnerabilities.
Actual:
Unhandled exception happened: Invalid specifier: '=2.7.0'Fix
Wrap the
SpecifierSet()call insafety/scan/ecosystems/python/main.pyin a try/except to catchInvalidSpecifier, skip the invalid entry, and log a warning. This allows the scan to continue processing the remaining valid specifiers.Fixes #873