feat: include CVE and severity info in JSON vulnerability entries (fixes #578)#892
Open
janderik wants to merge 1 commit into
Open
feat: include CVE and severity info in JSON vulnerability entries (fixes #578)#892janderik wants to merge 1 commit into
janderik wants to merge 1 commit into
Conversation
Previously the JSON output (safety scan --output json) only included safety vulnerability IDs (e.g. '50885') without CVE references or severity information, even though the data was available internally. Now each vulnerability entry in the JSON report includes: - CVE: list of CVE identifiers associated with the vulnerability - severity: CVSSv3 severity details (base_severity, vector, base_score) This addresses issue pyupio#578 and makes the JSON output self-contained for programmatic consumption without requiring the --detailed_output flag. Implementation: - _build_vuln_lookup(): builds a (package, vuln_id) -> CVE/severity map - inject_cve_into_vulnerabilities(): enriches each JSON vuln entry - Called unconditionally (not behind --detailed_output) in process_report()
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The JSON output from safety scan --output json only includes safety's internal vulnerability IDs (e.g. "50885"), making it difficult for users to correlate results with known CVEs.
This PR adds CVE references and CVSSv3 severity information directly into each vulnerability entry in the JSON output, making the report self-contained for programmatic consumption.
Changes
New functions in safety/scan/command.py:
Modified flow in process_report():
Example
Before:
json { "id": "50885", "vulnerable_spec": ">=1.5,<2.7.4" }After:
json { "id": "50885", "vulnerable_spec": ">=1.5,<2.7.4", "CVE": ["CVE-2022-1234"], "severity": { "base_severity": "HIGH", "base_score": 7.5, "vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N" } }Related