Fix sprite transparency: remove purple background from Mario sprite sheet#1
Open
qa-philipp-bauhofer wants to merge 1 commit into
Open
Conversation
The sprite PNG used opaque colored backgrounds (three variants: #002980, #0000A8, #9290FF) as a legacy color-key convention, causing a visible purple rectangle to render around Mario whenever he walked in front of trees or other background elements. Fixed by applying flood-fill from the image boundary to remove all connected background regions, preserving internal sprite pixels. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/sprite.pngsprite sheet used opaque colored backgrounds (three color variants:#002980,#0000A8,#9290FF) as a legacy NES-era color-key convention instead of proper alpha-channel transparencyWhat changed
assets/sprite.png— background pixels replaced with alpha=0 (transparent):(0, 41, 140)→ 113,072 px transparentWhat a reviewer should know
Player.ts(idle + 3 walk frames at y=8) were verified post-fix: ~40–52% of each cell is now transparent, consistent with character sprite shapesTest plan
npm run devand openhttp://localhost:8000🤖 Generated with Claude Code