🚀 Feat(eldom): add sensors for IoT flat boiler device type#45
Open
ptfly wants to merge 2 commits into
Open
Conversation
ptfly
commented
Mar 20, 2026
ptfly
commented
- Expose heater state, chamber 1/2 temps, and target temp as HA sensors
- Add chamber-level temperature and mode-aware target temp properties to FlatIoTEldomBoiler
- Expose heater state, chamber 1/2 temps, and target temp as HA sensors - Add chamber-level temperature and mode-aware target temp properties to FlatIoTEldomBoiler
- Extract _IoTBaseSensor to reduce duplication across IoT sensor classes - Add sensors: current temp, powerful target temp, eco target temps, extra save rate, ready/remain/delayed start/smart end times - Expose new boiler properties for the added sensors - Remove redundant async_config_entry_first_refresh calls - Import FlatBoilerDetails from local iot_models_override
Member
danielgospodinow
left a comment
danielgospodinow
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I've left some comments.
|
|
||
|
|
||
| @dataclass | ||
| class FlatBoilerDetails: |
Member
There was a problem hiding this comment.
Why have the User and flat boiler details in this repo? Those are supposed to be in the pyeldom lib.
Member
There was a problem hiding this comment.
This whole file is supposed to be in another repo.
| # ─── IoT Flat Boiler Sensors ───────────────────────────────────────────────── | ||
|
|
||
|
|
||
| class _IoTBaseSensor(SensorEntity, CoordinatorEntity): |
Member
There was a problem hiding this comment.
Let's avoid having another class and be consistent with how we define other sensors. Even if it means more boilerplate.
| self.async_write_ha_state() | ||
|
|
||
|
|
||
| # ─── IoT Flat Boiler Sensors ───────────────────────────────────────────────── |
Member
There was a problem hiding this comment.
Let's remove this comment.
|
|
||
| eldom_data: EldomData = hass.data[DOMAIN][entry.entry_id] | ||
|
|
||
| await eldom_data.coordinator.async_config_entry_first_refresh() |
Member
There was a problem hiding this comment.
Why did we remove this?
|
|
||
|
|
||
| @dataclass | ||
| class Device: |
Member
There was a problem hiding this comment.
This (and the other classes) is a duplicate of what we have already in pyeldom.
martinhrvn
added a commit
to martinhrvn/homeassistant-eldom
that referenced
this pull request
May 4, 2026
Adds chamber/target temp/heater/ready/remain time properties to FlatIoTEldomBoiler and corresponding HA sensors. Based on qbaware#45 with reviewer feedback addressed: no override models module, no section divider comment, async_config_entry_first_refresh kept, naming consistent with existing sensors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.