Wire timeout flag to requests#129
Merged
Merged
Conversation
bd0aa29 to
c62cefb
Compare
timvisee
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire --timeout into per-request server-side timeouts
--timeoutonly configured the tonic channel deadline (client-side).Qdrant aborts long operations using a separate per-request timeout field on the request payload, so against a slow on disk search the server returns a Timeout error before the channel deadline.
Thread
args.timeoutinto every request builder that exposes a server-side.timeout():Also added added a fixed 5-second cushion to the channel deadline so the server's structured timeout error reliably wins the race over the transport deadline.
Doc on --timeout updated to reflect the dual scope (channel deadline + server-side request timeout where supported).
Collection-management builders also expose .timeout() but are left untouched for this fix.