Skip to content

FROMLIST: wifi: ath10k: filter non-UTF testmode events - #880

Open
linghuiwu-star wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
linghuiwu-star:ath10k-filter-non-utf-testmode-events-qcom-6.18
Open

FROMLIST: wifi: ath10k: filter non-UTF testmode events#880
linghuiwu-star wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
linghuiwu-star:ath10k-filter-non-utf-testmode-events-qcom-6.18

Conversation

@linghuiwu-star

Copy link
Copy Markdown

When UTF monitor is enabled, ath10k forwards WMI events to nl80211 testmode. Non-UTF events can therefore be delivered to userspace and confuse FTM tools which expect only UTF responses.

Only forward known UTF event IDs from WMI event namespaces that route events through ath10k_tm_event_wmi(), and drop other WMI events while UTF monitor is active. READY events are still handled by the normal WMI receive path.

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.3.7.c5-00093.2-QCAHLSWMTPL-1

Link: https://lore.kernel.org/r/20260730023226.707008-1-linghui.wu@oss.qualcomm.com

CRs-Fixed:4627410

When UTF monitor is enabled, ath10k forwards WMI events to nl80211
testmode. Non-UTF events can therefore be delivered to userspace and
confuse FTM tools which expect only UTF responses.

Only forward known UTF event IDs from WMI event namespaces that route
events through ath10k_tm_event_wmi(), and drop other WMI events while UTF
monitor is active. READY events are still handled by the normal WMI
receive path.

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.3.7.c5-00093.2-QCAHLSWMTPL-1

Signed-off-by: Linghui Wu <linghui.wu@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260730023226.707008-1-linghui.wu@oss.qualcomm.com
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4627410 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4627410

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #880

PR: #880
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30534798019

# Error File:Line PR-introduced? Root Cause
1 'WMI_TLV_PDEV_UTF_EVENTID' undeclared drivers/net/wireless/ath/ath10k/testmode.c:33 Yes PR adds new function ath10k_tm_is_utf_event() that references undefined constant WMI_TLV_PDEV_UTF_EVENTID
2 control reaches end of non-void function [-Werror=return-type] drivers/net/wireless/ath/ath10k/testmode.c:34 Yes Cascading error from Error #1 — incomplete return statement due to undeclared identifier

Verdict

Both errors are introduced by this PR. The patch references a WMI event ID constant that does not exist in the kernel headers.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #880

PR: #880
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30534798019

# Error File:Line PR-introduced? Root Cause
1 Undeclared identifier WMI_TLV_PDEV_UTF_EVENTID drivers/net/wireless/ath/ath10k/testmode.c:33 Yes PR adds reference to undefined constant in new function ath10k_tm_is_utf_event()
2 Control reaches end of non-void function drivers/net/wireless/ath/ath10k/testmode.c:34 Yes Cascading error from undeclared identifier prevents compiler from verifying return path

Verdict

Both errors are introduced by this PR. The constant WMI_TLV_PDEV_UTF_EVENTID does not exist in the kernel tree.

📎 Detailed analysis: Full report

@linghuiwu-star

Copy link
Copy Markdown
Author

Hi @qualcomm-linux/qualcomm-kernel-maint,

Could you please help review and approve this PR when you get a chance?
The internal review has been completed, and this PR is now waiting for the required kernel maintainer approval.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants