platforms/shikra-evk: update additional_chipid in contents.xml.in - #146
Merged
Merged
Conversation
vivpuar
requested review from
Dmitry Baryshkov (lumag),
Nicolas Dechesne (ndechesne) and
Viswanath Kraleti (vkraleti)
as code owners
July 24, 2026 09:27
Dmitry Baryshkov (lumag)
requested changes
Jul 25, 2026
| <product_name>CQ2390.LE.0.0</product_name> | ||
| <chipid flavor="default" storage_type="emmc" flash_phase="1">SHIKRA</chipid> | ||
| <additional_chipid>CQ2390,CQ2390M,CQ2390S</additional_chipid> | ||
| <additional_chipid>CQ2390,CQ2390M,CQ2390S,IQ2390S</additional_chipid> |
Contributor
There was a problem hiding this comment.
Other way around. When you think about something, you start with problem, don't you?
The "additional_chipid" misses one of the SKUs of the Shikra SoC used on the EVK, IQ2390S, so Axiom doesn't schedule the testing on those boards. Add missing SKU to the list.
The 'additional_chipid' misses one of the SKUs of the Shikra SoC used on the EVK, IQ2390S, so Axiom doesn't schedule the testing on those boards. Add missing SKU 'IQ2390S' to the list. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Dmitry Baryshkov (lumag)
approved these changes
Jul 27, 2026
Dmitry Baryshkov (lumag)
merged commit Jul 27, 2026
6dd6db4
into
qualcomm-linux:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'IQ2390S' chipe ID to additional_chipid in contents.xml.in file as it is required for axiom flashing.