qcom_ptool: drop shebangs and executable bits from package modules - #148
Open
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Open
qcom_ptool: drop shebangs and executable bits from package modules#148Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Ali Erdinc Koroglu (aekoroglu) wants to merge 1 commit into
Conversation
Ali Erdinc Koroglu (aekoroglu)
requested review from
Dmitry Baryshkov (lumag),
Nicolas Dechesne (ndechesne) and
Viswanath Kraleti (vkraleti)
as code owners
July 26, 2026 08:12
Contributor
Author
These files are importable Python modules located in Therefore,
|
Contributor
|
Okay, please turn that into a commit message. |
The files under qcom_ptool/ are importable Python modules installed into /usr/lib/python3.x/site-packages/qcom_ptool/. They are not meant to be executed directly, so they should carry neither a shebang line nor executable permissions, and should be installed as 0644. Keeping the shebangs while packaging the modules non-executable makes rpmlint fail with: qcom-ptool.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/qcom_ptool/gen_contents.py 644 /usr/bin/env python3 qcom-ptool.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/qcom_ptool/gen_partition.py 644 /usr/bin/env python3 qcom-ptool.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/qcom_ptool/msp.py 644 /usr/bin/env python3 qcom-ptool.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/qcom_ptool/ptool.py 644 /usr/bin/env python3 qcom-ptool.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/qcom_ptool/utils.py 644 /usr/bin/env python3 Remove the shebang from gen_contents.py, gen_partition.py, msp.py, ptool.py and utils.py, and clear their executable bits (100755 ->100644). Entry points are unaffected: the modules are invoked via the console script wrapper, which imports them. Signed-off-by: Ali Erdinc Koroglu <ali.koroglu@oss.qualcomm.com>
Ali Erdinc Koroglu (aekoroglu)
force-pushed
the
shebang
branch
from
July 28, 2026 14:56
f137253 to
b1e8ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the shebangs, and the executable bit where it is set. No functional change.