Repository navigation
Conversation
Signed-off-by: Hem Agnihotri <hemagnih@qti.qualcomm.com>
Amit Raj (quic-amitraj)
left a comment
Contributor
There was a problem hiding this comment.
amarquic lets fix the DCO issue and correct the PR title. Other changes LGTM.
Signed-off-by: amarshar <amarshar@qti.qualcomm.com>
Signed-off-by: amarshar <amarshar@qti.qualcomm.com>
Signed-off-by: amarshar <amarshar@qti.qualcomm.com>
Signed-off-by: amarshar <amarshar@qti.qualcomm.com>
Signed-off-by: amarshar <amarshar@qti.qualcomm.com>
Signed-off-by: amarshar <amarshar@qti.qualcomm.com>
amarquic
force-pushed
the
amarshar/weight-free-decode-moe-ep
branch
from
October 30, 2026 06:49
d420e52 to
0db5edd
Compare
Ann Kuruvilla (quic-akuruvil)
left a comment
Contributor
There was a problem hiding this comment.
Test coverage table is descriptive and good. It would be helpful to include the test file path also in the table for easy lookup. test_file_path::test_name
Contributor
Author
Updated |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Add weight-free MoE expert-parallel and decode-BMM coverage
Summary
This PR adds weight-free QAIC tests for MoE prefill and decode configurations, makes QAIC test core selection device-aware, and configures Jenkins to store prepared weight-free checkpoints in the test-owned cache.
Changes
Cover MoE prefill with expert parallelism and decode with
decode_bmm.Add expert-parallel decode coverage for selected VLM and continuous-batching tests.
Check the configured MoE flavor and expert-parallel chunk size through model hash parameters.
Compare QAIC-generated tokens with Hugging Face output for the additional expert-parallel decode paths.
Replace hardcoded QAIC core counts with
DEFAULT_AIC_NUM_CORES.Add the
use_onnx_subfunctionsguard to the Qwen3-MoE parity test.Keep generated weight-free checkpoints under
QEFF_HOMEfor test cleanup.Set
QEFF_WF_HOMEin Jenkins to:Preserve the Gemma4 vision overflow fix by folding standardization scales before multiplying by the root hidden size.
Test coverage and configurations
test_file_path::test_name)tests/weight_free/test_disaggregated.py::test_weight_free_disaggregated_prefill_and_decode[qwen3-moe]tiny-random/qwen3-moedecode_bmmdecode;mxint8_kv_cache=Falsetests/weight_free/test_disaggregated.py::test_weight_free_disaggregated_prefill_and_decode[gpt-oss]tiny-random/gpt-ossdecode_bmmdecode;mxint8_kv_cache=Falsetests/weight_free/test_disaggregated.py::test_weight_free_vlm_disaggregated_prefill_and_decode[qwen3-vl-moe]tiny-random/qwen3-vl-moedecode_bmmand expert-parallel decode paths; HF token parity;mxint8_kv_cache=Falsetests/weight_free/test_disaggregated.py::test_weight_free_vlm_disaggregated_prefill_and_decode[gemma-4-moe]tiny-random/gemma-4-moedecode_bmmand expert-parallel decode paths; HF token parity;mxint8_kv_cache=Falsetests/weight_free/test_disaggregated.py::test_weight_free_qwen3_moe_disagg_cb_kv_handoff_and_hf_parity[local_qwen3_moe_prefill2_decode1_stages2]mxint8_kv_cache=Falsetests/weight_free/test_disaggregated.py::test_weight_free_gpt_oss_disagg_cb_kv_handoff_and_hf_parity[tiny_model_prefill2_decode1_stages2]tiny-random/gpt-ossmxint8_kv_cache=Falsetests/weight_free/test_on_qaic_vlm.py::test_weight_free_vlm_multi_specialization_hf_qaic_parity[qwen3.5-moe]tiny-random/qwen3.5-moedecode_bmmand expert-parallel decode paths; HF token parity. MXINT8 KV cache is omitted and remains disabled by default.