build: Fix pkg-config Cflags to match header install path - #20
Open
Vishnu Santhosh (quic-vishsant) wants to merge 1 commit into
Open
build: Fix pkg-config Cflags to match header install path#20Vishnu Santhosh (quic-vishsant) wants to merge 1 commit into
Vishnu Santhosh (quic-vishsant) wants to merge 1 commit into
Conversation
Headers install to $(includedir)/qmi_framework (per pkginclude_HEADERS
in Makefile.am), but Cflags only added -I${includedir}, one directory
short. Consumers using pkg-config --cflags qmi-framework could not
locate headers with a plain #include "qmi_idl_lib.h".
Signed-off-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
Vishnu Santhosh (quic-vishsant)
force-pushed
the
fix-pc-in-include-path
branch
from
July 17, 2026 02:12
1bc6a65 to
2b28fad
Compare
Deepak Kumar Singh (quic-deesin)
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headers install to "$(includedir)/qmi_framework (per pkginclude_HEADERS in Makefile.am), but Cflags only added -I${includedir}," one directory short. Consumers using pkg-config --cflags qmi-framework could not locate headers with a plain #include "qmi_idl_lib.h".