Skip to content

fix: --today uses local calendar date, not UTC #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DTTerastar merged 1 commit into from
Apr 21, 2026
Merged

fix: --today uses local calendar date, not UTC #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions internal/cronoclient/daterange.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ import (

const dateLayout = "2006-01-02"

// DateRange is an inclusive [Start, End] window in UTC.
// DateRange is an inclusive [Start, End] window. Only the calendar date
// (YYYY-MM-DD) of each endpoint is sent to Cronometer's export endpoints,
// so the time-of-day and zone on these values don't round-trip — but the
// calendar date is resolved in the user's local zone so that --today
// matches the day the user sees in the Cronometer UI.
type DateRange struct {
Start time.Time
End time.Time
Expand All @@ -29,17 +33,18 @@ func AddDateRangeFlags(cmd *cobra.Command) {

// ParseDateRangeFromFlags reads the date-range flags off cmd and resolves
// them into a concrete DateRange. Default when no flags are passed: the
// last 7 days ending today (UTC).
// last 7 days ending today. "Today" is the user's local calendar day.
func ParseDateRangeFromFlags(cmd *cobra.Command) (DateRange, error) {
startStr, _ := cmd.Flags().GetString("start")
endStr, _ := cmd.Flags().GetString("end")
days, _ := cmd.Flags().GetInt("days")
today, _ := cmd.Flags().GetBool("today")
return resolveDateRange(startStr, endStr, days, today, time.Now().UTC())
return resolveDateRange(startStr, endStr, days, today, time.Now())
}

func resolveDateRange(startStr, endStr string, days int, today bool, ref time.Time) (DateRange, error) {
now := ref.Truncate(24 * time.Hour)
y, m, d := ref.Date()
now := time.Date(y, m, d, 0, 0, 0, 0, ref.Location())
var start, end time.Time

switch {
Expand Down
Loading