ci: move release trigger to 'release: published' - #2
Merged
Conversation
Goreleaser on tag-push was incoherent: the 'release.draft: true' flag only affected the GitHub release object, while the Homebrew tap push fired immediately — so drafts shipped broken casks pointing at assets only admins could download. New flow: - draft created by 'gh release create --draft' (or the UI) - user reviews and publishes when ready - 'release: published' event fires this workflow - goreleaser uploads assets and pushes cask atomically Also add 'skip_upload: auto' so casks are skipped for prerelease tags, and drop release-drafter (replaced by manual 'gh release create'). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously: tag-push triggered goreleaser which created a draft release AND pushed the cask to the tap immediately. The draft flag only gated the GitHub release object — the Homebrew cask shipped pointing at draft-release assets that 404 for non-admins. Incoherent.
New flow:
gh release create vX.Y.Z --draft --generate-notes(or create in UI)release: publishedevent fires this workflow → goreleaser uploads binaries and pushes the cask atomicallyChanges
.github/workflows/release.yml— triggeron: release: types: [published].goreleaser.yml— droprelease.draft: true(drafts are now externally managed); addskip_upload: autoso prereleases don't push to tap.github/release-drafter.yml+ workflow — replaced bygh release create --draft --generate-notesTest plan
gh release create v0.1.1 --draft --generate-notesgh release edit v0.1.1 --draft=falsequantcli/homebrew-tap🤖 Generated with Claude Code