-
Notifications
You must be signed in to change notification settings - Fork 108
Fix QROM documentation latex rendering issues #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+66
−66
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
678198c
try mathrm
Gopal-Dahale 10d95fb
fixed deleted backslashes
Gopal-Dahale 3ea3935
update \text with \mathrm in docstring
Gopal-Dahale 12475fa
Merge branch 'main' into fix1667
Gopal-Dahale 4fb0324
Merge branch 'main' into fix1667
mpharrigan e99fe5a
Merge branch 'main' into fix1667
mhucka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LaTeX expressions in the cost section are malformed. Specifically:
\mathrmis a command that expects its argument in curly braces{...}, not parentheses(...). Using\mathrm(...)only applies the font to the opening parenthesis.\mathcal{O}(...)expressions (e.g., line 158 and 163 are missing closing parentheses).qrom.py, from which this section is autogenerated, has not been updated in this PR. Manual changes here will be lost upon the next documentation build. Please updateqrom.pyand regenerate the notebooks.