fix: unlock no seed reveal#282
Open
ahmed-tarek-salem wants to merge 2 commits into
Open
Conversation
The 'Install commitlint' step ran 'yarn add conventional-changelog-conventionalcommits', which now resolves to a version depending on @conventional-changelog/template@1.2.1 (requires Node >=22) and fails on the Node 20 runner. commitlint, config-conventional, and conventional-changelog-conventionalcommits@^7 are already pinned in package.json/ yarn.lock, so 'yarn install --frozen-lockfile' covers them.
Unlock previously called revealSeed() (decrypting a seed to plaintext) just to run a private/public key-match check and detect watch-only wallets. That decrypted the user's first seed on every unlock, needlessly widening the attack surface. Replace it with WalletService.hasValidKeyPair(), which validates the key pair internally and returns a boolean without ever returning or storing the plaintext seed. Watch-only wallets are detected from metadata (isOnlyWatch) with no decryption at all. Behavior is otherwise unchanged. revealSeed() is now only called when a seed is genuinely needed (send, backup, signing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.