Add cheat enable tag, right now the enable tag from Cheat data class …#1
Open
huhao1987 wants to merge 3 commits into
Open
Add cheat enable tag, right now the enable tag from Cheat data class …#1huhao1987 wants to merge 3 commits into
huhao1987 wants to merge 3 commits into
Conversation
…is not working, it was set as always true in method setCodeList in MelonDS.cpp.
Owner
|
Hi! Thanks for your interest in the project! Unfortunately, the scenario you described it not a problem. Cheat management on the Android port works differently from the PC version. The Android app is responsible for loading only the cheats that are enabled for the ROM currently running. As such, the list of cheats that reach the emulator are always enabled. That's why Since you assumed this was a problem, obviously something is not clear in the logic. Let me know if you have any further suggestions with this new information in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cheat enable tag, right now the enable tag from Cheat data class is not working, it was set as always true in method setCodeList in MelonDS.cpp.