Repository navigation
Close ZIP validation/extraction race with private snapshots - #34
Merged
Merged
Conversation
raiseCatError
marked this pull request as ready for review
October 16, 2026 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final ZIP extraction safety review
ZIP extraction now creates a fresh permission-restricted staging directory on the user-selected destination volume and streams the archive into a private regular file using 1 MiB chunks, with a 2 GB archive-size cap and cancellation checks. This avoids the replacement race between ZIP preflight and invoking
unzip, includingFileManager.copyItempreserving source symlinks.Tuck validates the private snapshot, comparing every entry's central and local filename/method/flags/bounds before passing the same validated snapshot to the extractor. The extracted tree is checked in a separate nested contents directory, and only the finished extracted folder is published. The copied ZIP and temporary staging are removed afterward. Invalid or missing selections fail closed. README documents disk-space requirements.
Focused regression
Verification gates
No release/tag or local machine installation. Merge only after the final head passes both Mac CI stages.