Skip to content

chore: remove nox#563

Merged
joshdimanteto merged 2 commits into
developfrom
remove-nox
Jun 17, 2026
Merged

chore: remove nox#563
joshdimanteto merged 2 commits into
developfrom
remove-nox

Conversation

@joshdimanteto

@joshdimanteto joshdimanteto commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes Nox from the repository. Because the project is now pinned to a single Python version, a multi-version test runner is no longer necessary
Changes:

  • Removed noxfile.py.
  • Updated CI workflows to run tests directly via pytest , flake8 and black.
  • Updated ReadME

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?

Agile Board Tracking

closes #566

@joshdimanteto joshdimanteto marked this pull request as ready for review June 17, 2026 09:27

@patrick-austin patrick-austin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally it looks OK to me, but I think we might be calling poetry install repeatedly when we only need it once in the CI? Unless there's something too subtle for me to pick up on going on here.

Comment thread .github/workflows/ci-build.yml
Base automatically changed from remove-src-directory to develop June 17, 2026 12:41
@joshdimanteto joshdimanteto merged commit 716e989 into develop Jun 17, 2026
7 checks passed
@joshdimanteto joshdimanteto deleted the remove-nox branch June 17, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants