Repository navigation
fix: align UTF-8 decoding across payload utilities - #30
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #26
Closes #27
Closes #28
Summary
Consecutive malformed UTF-8 bytes were collapsed into one replacement character in three utilities. Parser and Parameters also retained BOMs where the pinned TextDecoder removes them, so BOM-prefixed JSON could become a string or fail transformation. Parser's gzip JSON path split truncated sequences differently from the reference.
Reuse the existing Commons UTF-8 decoder, retaining each path's TextDecoder/Buffer BOM behavior and Parser fallback order. These three issues share one decoding problem, so they map to this focused PR. The separately tested Signer fix was merged as PR #29 before this work began.
Add 56 fixed outcomes generated from the actual TypeScript 2.35.0 packages and a reproducible generator. Record the module review scope, baseline evidence and local Linux limitations.
Testing
Risks and compatibility
No public API or dependency versions change. Outputs for malformed UTF-8 and BOM-prefixed inputs now follow the pinned reference, including correctly parsing BOM-prefixed plain JSON. Gzip retains its separate BOM behavior and existing fallback/error policy. Arbitrary malformed Unicode, service and performance gates retain their documented scope.
Release notes
Checklist