Upgrade framework to rails 8.0#21308
Open
dwelch-r7 wants to merge 3 commits into
Open
Conversation
dwelch-r7
force-pushed
the
rails-8.0-upgrade
branch
from
672ab3a to
ccabb2e
Compare
adfoster-r7
reviewed
Apr 15, 2026
dwelch-r7
force-pushed
the
rails-8.0-upgrade
branch
3 times, most recently
from
52f6d4c to
4d2c8b4
Compare
dwelch-r7
changed the title
Comment on lines
+13
to
+20
| def self.define_element(name, code_generator:, method_name: name) | ||
| # Removed 'return if method_defined?(name)' guard that conflicts with | ||
| # Metasploit's Kernel select patch (rex.rb adds select to Kernel) | ||
| code_generator.class_eval do |batch| | ||
| batch << "\n" << | ||
| "def #{method_name}(content = nil, escape: true, **options, &block)" << | ||
| " tag_string(#{name.inspect}, content, options, escape: escape, &block)" << | ||
| "end" |
dwelch-r7
force-pushed
the
rails-8.0-upgrade
branch
from
9592cca to
bf421ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade framework to rails 8.0, initial PR to run through CI, do not merge