Skip to content

Adds support for nested directories #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dledda-r7 merged 4 commits into from
May 11, 2026
Merged

Adds support for nested directories #293

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
654941f
Adds base for nested mkdir
msutovsky-r7 Feb 19, 2026
80b6b62
Adds additional checks for mkdir execution
msutovsky-r7 Apr 9, 2026
3caa7e0
Replace eio_mkdir with mkdir for directory creation
dledda-r7 May 8, 2026
f80c174
fix: mingw mkdir wrong argument error
dledda-r7 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 80 additions & 2 deletions mettle/src/stdapi/fs/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,89 @@ fs_cb(eio_req *req)
struct tlv_packet *
fs_mkdir(struct tlv_handler_ctx *ctx)
{
const char *path = tlv_packet_get_str(ctx->req, TLV_TYPE_DIRECTORY_PATH);
char * dir;
char * base_dir;
char * tmp;
struct stat f_info;
char * path_dup;
char *path = tlv_packet_get_str(ctx->req, TLV_TYPE_DIRECTORY_PATH);

if (path == NULL) {
return tlv_packet_response_result(ctx, TLV_RESULT_EINVAL);
}

eio_mkdir(path, 0777, 0, fs_cb, ctx);
path_dup = strdup(path);

if (path_dup == NULL) {
return tlv_packet_response_result(ctx, TLV_RESULT_ENOMEM);
}

// take into account null byte at the end of path and the one we add in sprintf
base_dir = malloc(strlen(path_dup)+2);

if(base_dir == NULL)
{
free(path_dup);
return tlv_packet_response_result(ctx, TLV_RESULT_ENOMEM);
}

tmp = malloc(strlen(path_dup)+2);

if(tmp == NULL)
{
free(path_dup);
free(base_dir);
return tlv_packet_response_result(ctx, TLV_RESULT_ENOMEM);
}

dir = strtok(path_dup, "/");

//address absolute paths — check original path since strtok modifies path_dup
if (path[0] == '/')
{
sprintf(base_dir, "/%s/", dir);
}
else
{
sprintf(base_dir, "%s/", dir);
}
Comment thread
dledda-r7 marked this conversation as resolved.

while(dir != NULL)
{
#ifdef _WIN32
if(stat(base_dir, &f_info) != 0)
#else
if(lstat(base_dir, &f_info) != 0)
#endif
{
#ifndef __MINGW32__
if(mkdir(base_dir, 0777) != 0)
Comment thread
dledda-r7 marked this conversation as resolved.
#else
if(mkdir(base_dir) != 0)
#endif
{
free(path_dup);
free(base_dir);
free(tmp);
return tlv_packet_response_result(ctx, errno);
}
}
memset(&f_info, 0, sizeof(struct stat));
dir = strtok(NULL, "/");
if(dir != NULL)
{
sprintf(tmp, "%s%s/", base_dir, dir);
strcpy(base_dir, tmp);
}
}

struct tlv_packet *p = tlv_packet_response_result(ctx,TLV_RESULT_SUCCESS);

tlv_dispatcher_enqueue_response(ctx->td, p);
tlv_handler_ctx_free(ctx);
Comment thread
dledda-r7 marked this conversation as resolved.
free(tmp);
free(base_dir);
free(path_dup);
return NULL;
}

Expand Down Expand Up @@ -887,3 +964,4 @@ void file_register_handlers(struct mettle *m)
};
channelmgr_add_channel_type(cm, "stdapi_fs_file", &cbs);
}

Loading