Combine sampling primitive calls into fewer TUs to decrease size#5583
Open
ChuckHastings wants to merge 1 commit into
Open
Combine sampling primitive calls into fewer TUs to decrease size#5583ChuckHastings wants to merge 1 commit into
ChuckHastings wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ChuckHastings
added
improvement
seunghwak
approved these changes
Jul 10, 2026
seunghwak
left a comment
seunghwak
left a comment
Contributor
There was a problem hiding this comment.
LGTM besides the minor issues below.
| BreakStringLiterals: true | ||
| ColumnLimit: 100 | ||
| CommentPragmas: '^ IWYU pragma:' | ||
| CommentPragmas: '^ ?[*]? ?(IWYU pragma:|SPDX-)' |
Contributor
There was a problem hiding this comment.
What is this? Did you pull updates from another unmerged PR?
Contributor
There was a problem hiding this comment.
We probably want the version in #5582. Please see rapidsai/build-planning#303 and that PR's description for details.
Contributor
There was a problem hiding this comment.
Should this be .cuh? Or can be .hpp?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #5574.
We get a pretty good reduction in binary size by combining the TUs that call the sampling primitives. We'll start there, since this preserves the header-only design aspect of the primitives.
libcugraph_common.solibcugraph.solibcugraph_mg.so