Skip to content

Cleanup downstream genet patches#7297

Open
nbuchwitz wants to merge 5 commits intoraspberrypi:rpi-6.18.yfrom
nbuchwitz:devel/genet-cleanup
Open

Cleanup downstream genet patches#7297
nbuchwitz wants to merge 5 commits intoraspberrypi:rpi-6.18.yfrom
nbuchwitz:devel/genet-cleanup

Conversation

@nbuchwitz
Copy link
Copy Markdown
Contributor

@nbuchwitz nbuchwitz commented Mar 30, 2026

Spring cleaning part 2 - genet driver:

Reverted:

  • 712989f ("net: bcmgenet: Add 'eee' module parameter") - the genet.eee=N bootarg is superseded by eee-broken-* DT properties (54a9cd7) and upstream phylib-managed EEE (908c344, net-next, backported in EEE patches #7270).
  • 09d1901 ("bcmgenet: Disable skip_umac_reset by default") and dfad8d6 ("net: bcmgenet: Workaround #2 for Pi4 Ethernet fail") - the skip_umac_reset workaround and its default toggle are both superseded by upstream 88f6c8b ("net: bcmgenet: keep MAC in reset until PHY is up", v6.0).
  • bd61974 ("net: genet: enable link energy detect powerdown for external PHYs") - replaced by adding brcm,powerdown-enable to the Pi 4B and CM4 PHY nodes in device tree, matching what Pi 5 and CM5 already do.

Add brcm,powerdown-enable to the external PHY nodes on Pi 4B and CM4.
This puts the BCM54210PE PHY into a low-power state when the link is
down, reducing power consumption when no cable is connected. This is
the same approach already used by Pi 5 and CM5.

Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet