Reject trailing newlines in CounterExample method-name validation#22
Merged
Conversation
PCRE $ matches before a trailing \n. Switch the examples-method-name regex in CounterExample to \z so "<name>\n" is rejected instead of reaching the reflection/replay path. Hygiene: also anchor the two integer regexes in PropertyInterceptor (PROPERTY_RUNS / PROPERTY_SEED env parsers) and SeedStorage (seed-file reader) — env values and trim()'ed seed-file contents already strip the newline before the regex, so those changes are not observable through public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCRE
\$without/Dmatches before a trailing\n. Four regexes anchored with\$:CounterExample::toExamplesCode()Internal\PropertyInterceptor(PROPERTY_RUNS)intcastInternal\PropertyInterceptor(PROPERTY_SEED)intcastInternal\SeedStoragetrim()'ed seed-file content →intcastFix: anchor all four with
\\z. All patterns are in private methods/consts (bc-check stays green).Regression coverage:
CounterExampleTest::rejectsExamplesMethodNameWithTrailingNewline. The Tier-2 patterns are hygiene-only — env values andtrim()'ed file contents already strip the trailing\nbefore the regex runs, so the change is not observable through public API.Verification:
composer buildgreen (646 tests, 270408 assertions).Release: 2.7.1 —
Reject trailing newlines in CounterExample method-name validation.