Skip to content

Fix pandas-stubs mypy regression in validator output handling#278

Open
bgaidioz wants to merge 1 commit into
dependabot/uv/pandas-stubs-2.3.3.260113from
fix/pr271-pandas-stubs-mypy
Open

Fix pandas-stubs mypy regression in validator output handling#278
bgaidioz wants to merge 1 commit into
dependabot/uv/pandas-stubs-2.3.3.260113from
fix/pr271-pandas-stubs-mypy

Conversation

@bgaidioz
Copy link
Copy Markdown
Contributor

@bgaidioz bgaidioz commented May 4, 2026

Summary

  • replace replace({pd.NaT: None}) with typed-safe pandas null normalization in validator output paths
  • keep DataFrame and Series handling behavior the same while avoiding the stricter pandas-stubs replacement-map typing error
  • add regression tests for NaT in DataFrame and Series outputs

Why

PR #271 bumps pandas-stubs and makes uv run mypy . fail in CI on src/mxcp/sdk/validator/converters.py because the replace({pd.NaT: None}) pattern is typed more strictly.

Testing

  • uv run ruff check .
  • uv run black --check --diff .
  • uv run mypy .
  • env -u OP_SERVICE_ACCOUNT_TOKEN uv run pytest --cov=src/mxcp --cov-report=xml --cov-report=term-missing

Notes

  • The full local pytest run only needed OP_SERVICE_ACCOUNT_TOKEN unset because one existing config test assumes that variable is absent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant