Fix pandas-stubs mypy regression in validator output handling#278
Open
bgaidioz wants to merge 1 commit into
Open
Fix pandas-stubs mypy regression in validator output handling#278bgaidioz wants to merge 1 commit into
bgaidioz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace({pd.NaT: None})with typed-safe pandas null normalization in validator output pathspandas-stubsreplacement-map typing errorNaTin DataFrame and Series outputsWhy
PR #271 bumps
pandas-stubsand makesuv run mypy .fail in CI onsrc/mxcp/sdk/validator/converters.pybecause thereplace({pd.NaT: None})pattern is typed more strictly.Testing
uv run ruff check .uv run black --check --diff .uv run mypy .env -u OP_SERVICE_ACCOUNT_TOKEN uv run pytest --cov=src/mxcp --cov-report=xml --cov-report=term-missingNotes
OP_SERVICE_ACCOUNT_TOKENunset because one existing config test assumes that variable is absent.