Rbbydotdev cli proof of concept#12
Open
rbbydotdev wants to merge 4 commits into
Open
Conversation
Tightened clasp integration for clasp 2.5 Moved clasp commands to Clasp class for insulated and easier clasp interaction api Added zod schema for config add eslint
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rbbydotdev
pushed a commit
that referenced
this pull request
Jul 20, 2026
useGoogleTimeslots' failure handler set the error but never set status to
"error", so status stayed "pending": the loading overlay spun forever and
the error dialog (gated on status === "error") never opened. Add
setStatus("error").
App init's isOwner() promise had no withFailureHandler, so a thrown
isOwner() left it forever pending and hung the app on its initial spinner.
Add withFailureHandler(reject), matching the adjacent getConfig() call so
the outer try/catch handles it. (Findings #2, #12/#29.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is building on @edahlseng 's original PR #7
Still some outstanding implementations needed. A nice to have would also be some tests.
@edahlseng any thoughts? Would you like to continue work on this?