My first pull request#5
Open
APGRoboCop wants to merge 744 commits into
Open
Conversation
pongo1231
pushed a commit
to pongo1231/rcbot2
that referenced
this pull request
Jun 13, 2021
We use a link to build_info to avoid regenerating every file depending on bot_const.h after every update. Versioning based off of SourceMod. Closes rcbotCheeseh#5.
Thread 1 "srcds_linux" received signal SIGSEGV, Segmentation fault. 0xe3905650 in CBotEntPropIndexToAThings (this=<optimized out>, num=<optimized out>, pEntData=<optimized out>, pEdictData=<optimized out>) at /home/linux/Dropbox/src/rcbot2/rcbot/entprops.cpp:335 335 /home/linux/Dropbox/src/rcbot2/rcbot/entprops.cpp: No such file or directory. (gdb) bt #0 0xe3905650 in CBotEntPropIndexToAThings (this=<optimized out>, num=<optimized out>, pEntData=<optimized out>, pEdictData=<optimized out>) at /home/linux/Dropbox/src/rcbot2/rcbot/entprops.cpp:335 #1 CBotEntPropGetEntProp (this=0xe4df1b4c <s_entprops>, entity=1, proptype=Prop_Send, prop=0xe3a1da00 "m_nPlayerCondEx", size=4, element=0) at /home/linux/Dropbox/src/rcbot2/rcbot/entprops.cpp:388 #2 0xe390aa09 in CTF2ConditionsTF2_IsPlayerInCondition (client=1, cond=TFCond_UberchargedHidden) at /home/linux/Dropbox/src/rcbot2/rcbot/tf2/conditions.cpp:72 #3 0xe389af20 in CBotTF2isEnemy (this=0x100a1da0, pEdict=0x10223da4, bCheckWeapons=<optimized out>) at /home/linux/Dropbox/src/rcbot2/utils/RCBot2_meta/bot_fortress.cpp:7656 #4 0xe383299f in CBotupdateStatistics (this=0x100a1da0) at /home/linux/Dropbox/src/rcbot2/utils/RCBot2_meta/bot.cpp:1965 #5 0xe3831555 in CBotthink (this=0x100a1da0) at /home/linux/Dropbox/src/rcbot2/utils/RCBot2_meta/bot.cpp:1009 #6 0xe38390fc in CBotsbotThink () at /home/linux/Dropbox/src/rcbot2/utils/RCBot2_meta/bot.cpp:3390 #7 0xe3900907 in RCBotPluginMetaHook_GameFrame ( this=0xe3aa3304 <g_RCBotPluginMeta>, simulating=<optimized out>) at /home/linux/Dropbox/src/rcbot2/utils/RCBot2_meta/bot_plugin_meta.cpp:814 #8 0xe3903ca5 in fastdelegateFastDelegate<void, bool>operator() ( this=<optimized out>, params=<optimized out>) --Type <RET> for more, q to quit, c to continue without paging-- at /home/linux/Dropbox/src/rcbot2/alliedmodders/metamod-source/core/sourcehook/FastDelegate.h:927 #9 __SourceHook_FHCls_IServerGameDLLGameFrame0CMyDelegateImplCall ( this=0x1009b8e0, p1=<optimized out>) at /home/linux/Dropbox/src/rcbot2/utils/RCBot2_meta/bot_plugin_meta.cpp:75 #10 0xeaf18710 in __SourceHook_FHCls_IServerGameDLLGameFramefalseFunc(bool) () from /home/debian/steamcmd/tf2n/tf/addons/sourcemod/bin/sourcemod.2.tf2.so #11 0xf654e5a8 in SV_Think(bool) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #12 0xf654ef4c in SV_Frame(bool) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #13 0xf65c9a42 in _Host_RunFrame_Server(bool) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #14 0xf65ca3e8 in _Host_RunFrame(float) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #15 0xf65d3d6b in CHostStateState_Run(float) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #16 0xf65d4110 in CHostStateFrameUpdate(float) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #17 0xf65d4263 in HostState_Frame(float) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #18 0xf662de7f in CEngineFrame() () --Type <RET> for more, q to quit, c to continue without paging-- from /home/debian/steamcmd/tf2n/bin/engine_srv.so #19 0xf662b6aa in CDedicatedServerAPIRunFrame() () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #20 0xf72fe7e3 in RunServer() () from bin/dedicated_srv.so #21 0xf662b3ea in CModAppSystemGroupMain() () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #22 0xf6678cf8 in CAppSystemGroupRun() () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #23 0xf662c434 in CDedicatedServerAPIModInit(ModInfo_t&) () from /home/debian/steamcmd/tf2n/bin/engine_srv.so #24 0xf72fe474 in CDedicatedAppSystemGroupMain() () from bin/dedicated_srv.so #25 0xf7415778 in CAppSystemGroupRun() () from bin/dedicated_srv.so #26 0xf7415778 in CAppSystemGroupRun() () from bin/dedicated_srv.so #27 0xf72e805a in main () from bin/dedicated_srv.so #28 0x080491d4 in main () (gdb)
…ck/Defend]) Some CTF (Attack/Defend) maps support
- Engineers will no longer use defend waypoint type, - Snipers with bow will no longer use sniper waypoint type
…of-Life Quality of Life + Sniper's fix (TEAM FORTRESS 2)
- Zombies attack disguised spies in zi_ maps - Zombies and Hale in zi_ and vsh_ maps see a Spy in a cloaked state when he has TF_COND_OFFENSEBUFF or TF_COND_CRITBOOSTED (Last 3 or the last red team member) - Bots now attack "tf_merasmus_trick_or_treat_prop" entity - koth_namicott map support - Bots attack "generic_actor" entity in ctf_pressure
…en---QoL) Quality of Life - Halloween Edition
- Moved entity tf_merasmus_trick_or_treat_prop to another file - Bots won't attack merasmus when tf_merasmus_trick_or_treat_prop in a map (unconfirmed) - Increased distance for capture in team_control_point"
- Changed Sniper's attack time - Bots won't attack enemy team when boss is spawned in Ghost Fort or in Eyeduct - Bots charges at Merasmus with TF_COND_HALLOWEEN_BOMB_HEAD
- Snipers will no longer use "sniper" waypoint type with bows
sv_quota_stringcmdspersecond is in the wrong place. this can cause a crash if the server decides to kick a bot
Copied from RedFox's FoXBot and adapted for RCBot2
BOSS maps support accepted!
Implement and declare CBotProfile::operator= to correctly copy numeric fields and string members (with self-assignment guard) and return *this; leave the copy constructor delegating to the assignment. Also fix a bounds check in CBotSquad::getMember by removing the invalid iMember < 0 test for a size_t index, preventing a pointless signed/unsigned comparison and ensuring proper out-of-range handling.
>> Add availability check for SourceMod entity-property helpers (CBotEntProp::isAvailable) and skip bot thinking until entprops are ready to prevent null-deref crashes. >> Include entprops header in bot code. >> Replace several function-static variables with proper stack locals (bot schedule, waypoint navigator) and make task state local/const to avoid shared state and potential bugs >> Make CBotSchedule non-copyable to prevent double-free, and initialize CCounterStrikeSourceMod::m_hBomb via default construction instead of NULL >> Miscellaneous small refactors and comments explaining the changes
Attempting to resolve issue #55 but requires some tests from our testers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is how you do a proper pull request, but let me know if thats how its done!