Open
Conversation
- Functional.maybeFuzz: evaluate fuzzFunction at input value (number.toDouble) rather than output value (scaleFunction(number.toDouble)), preventing double- scaling of relative fuzz through functions such as NaturalExponential - Functional.maybeFuzz: dispatch on fuzz style — use absolute derivative (derivativeFunction) for AbsoluteFuzz, relative derivative (derivativeFunction * x / scaleFunction) for RelativeFuzz - Fuzziness.monadicCombine: add opFuzz parameter and combine with functionFuzz via proper convolution, rather than arbitrary orElse - Fuzziness.monadicCombine: use independent = true — input measurement uncertainty and floating-point implementation error are independent sources - Correct several wrong test expectations exposed by the above fixes - Add AbsoluteFuzzRenderSpec with truth-table tests for getQualifiedString; four tests marked pending under issue #203 (getQualifiedString rewrite) - Log issue #203: getQualifiedString rewrite and mantissa rounding
Unit tests: 3,866 green, 10 amber. - Functional.maybeFuzz: dispatch on fuzz style — use absolute derivative (derivativeFunction) for AbsoluteFuzz, relative derivative (derivativeFunction * x / scaleFunction) for RelativeFuzz; evaluate fuzzFunction at input value (number.toDouble) not output value - Functional.toReal: combine propagated maybeFuzz with doublePrecision via FuzzyDouble.addFuzz, suppressing DP fuzz when real fuzz already present - Exponential.transformation, InversePower.transformation: use toReal for Real input cases, correctly propagating fuzz through convert/approximation/fuzzy - InversePower.transformation: add missing case to return None for imaginary input, fixing pre-existing hidden bug causing NaN propagation - Correct several wrong test expectations exposed by the above fixes - Log issue #203: getQualifiedString rewrite and mantissa rounding
Moved three extractors into Extractor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some updated dependencies