ci: speed up demo lint CI (npm + .angular cache)#108
Conversation
✅ Deploy Preview for ionic-theme-ios26 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| concurrency: | ||
| group: lint-${{ github.ref }} | ||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
🚩 cancel-in-progress is effectively a no-op for this workflow's PR trigger
The cancel-in-progress is set to true only when github.event_name == 'pull_request', but the pull_request trigger is limited to types: [opened] (line 7). This means a PR can only trigger one workflow run via the pull_request event (on open), so there's essentially nothing to cancel. Subsequent pushes to the PR branch trigger via the push event, where cancel-in-progress is false — so concurrent push-triggered runs on the same branch will queue rather than cancel each other. If the intent is to cancel redundant runs on rapid pushes to a PR branch, either cancel-in-progress should be unconditionally true, or the pull_request trigger should include synchronize.
Was this helpful? React with 👍 or 👎 to provide feedback.
Playwright test results
Details
|
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-ios26/pr-108/ |
rdlabo
force-pushed
the
chore/ci-cache-speedup
branch
from
c0c8e0c to
b471202
Compare
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-ios26/pr-108/ |
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-ios26/pr-108/ |
1 participant
Summary
Align the Angular lint CI to the winecode standard for faster builds.
Changes
setup-nodenpm cache (cache: npm+cache-dependency-path).angular/cache(Angular build cache) viaactions/cache~/.npm/node_modulesactions/cachestepsnode-versionto 24 (and bump actions to v5 where outdated)Effect
Subsequent runs restore the npm and Angular build caches, shortening lint/build/test.